Replace Vert.x in CruiseControlAPI with native HttpClient API from Java #10791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaselenge
force-pushed
the
vertx-removal-cc
branch
from
f4db806 to
1616376
Compare
tinaselenge
force-pushed
the
vertx-removal-cc
branch
2 times, most recently
from
6a608e2 to
933a36b
Compare
scholzj
reviewed
Nov 5, 2024
.../main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
Outdated
Show resolved
Hide resolved
.../main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
tinaselenge
force-pushed
the
vertx-removal-cc
branch
from
975ab51 to
81911d5
Compare
scholzj
approved these changes
Nov 7, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
katheris
reviewed
Nov 11, 2024
...n/java/io/strimzi/operator/cluster/operator/resource/cruisecontrol/CruiseControlApiImpl.java
Outdated
Show resolved
Hide resolved
...ava/io/strimzi/operator/cluster/operator/resource/cruisecontrol/CruiseControlClientTest.java
Show resolved
Hide resolved
|
Thanks @katheris for reviewing the PR. I have now added the missing join() for one of the tests and removed the unused variable. |
Signed-off-by: Gantigmaa Selenge <[email protected]>
tinaselenge
force-pushed
the
vertx-removal-cc
branch
from
b301fe4 to
5bb738b
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Nov 14, 2024
...n/java/io/strimzi/operator/cluster/operator/resource/cruisecontrol/CruiseControlApiImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gantigmaa Selenge <[email protected]>
|
Going to merge this. I don't think it needs a new regression running because latest commit doesn't have any big impact it was just a nit that @tinaselenge addressed based on my comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Replace use of Vertx HTTP and Future from CruiseControl API implementation with Java CompletableFuture and HTTP API.
Checklist
Please go through this checklist and make sure all applicable tasks have been done