Follow up on fixing stuck reconciliation on failed request rebalance #10720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
reviewed
Oct 15, 2024
.../main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Patierno <[email protected]>
ppatierno
force-pushed
the
fix-stuck-kafkarebalance-reconciliation
branch
from
5d5a35d to
abb94c8
Compare
Signed-off-by: Paolo Patierno <[email protected]>
scholzj
approved these changes
Oct 16, 2024
ShubhamRwt
reviewed
Oct 16, 2024
...t/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperatorTest.java
Outdated
Show resolved
Hide resolved
ShubhamRwt
reviewed
Oct 16, 2024
...t/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperatorTest.java
Outdated
Show resolved
Hide resolved
|
LGTM. Left some very very minor suggestions. |
Signed-off-by: Paolo Patierno <[email protected]>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ShubhamRwt
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR is a follow up for #10717.
It fixes a stuck
KafkaRebalancereconciliation in some other few places also adding corresponding tests using the "remove-brokers" to simulate and error in Cruise Control in PendingProposal (without session id, with refresh) as well as in Rebalancing (with refresh).Checklist
Please go through this checklist and make sure all applicable tasks have been done