Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system test] [doc] kafka package #10650

Merged
merged 12 commits into from
Oct 11, 2024
Merged

[system test] [doc] kafka package #10650

merged 12 commits into from
Oct 11, 2024

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Sep 27, 2024 •
edited
Loading

Type of change

  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

This PR covers the whole Kafka package with system test DOCs and also adds a kafka label.

Checklist

  • Write tests
  • Make sure all tests pass

@see-quick see-quick added this to the 0.44.0 milestone Sep 27, 2024
@see-quick see-quick self-assigned this Sep 27, 2024
@see-quick see-quick requested review from PaulRMellor and a team September 27, 2024 20:55
PaulRMellor
PaulRMellor approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Maros. I commented on the md as it was easier to read. Suggestions are mostly about consistency when reading through, but I left a couple of questions where I wasn't sure about something

@see-quick see-quick requested a review from a team October 1, 2024 09:58
im-konge
im-konge reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things, otherwise heroic work, thanks! 🚀

Frawless
Frawless reviewed Oct 3, 2024
View reviewed changes
systemtest/src/test/java/io/strimzi/systemtest/kafka/ConfigProviderST.java Outdated
Comment on lines 68 to 69
@Step(value = "Create necessary Role and RoleBinding for connector.", expected = "Role and RoleBinding are created and applied."),
@Step(value = "Deploy Kafka connector.", expected = "Kafka connector is successfully deployed."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connector -> KafkaConnector ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, updated all occurences

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then why this file has old formating?

@see-quick
[system test] [doc] kafka package
0d8d9a8 
Signed-off-by: see-quick <[email protected]>
@see-quick
polishing
8621457 
Signed-off-by: see-quick <[email protected]>
@see-quick
add Kafka docs
01f5aa1 
Signed-off-by: see-quick <[email protected]>
@see-quick
review from Paul
48357bf 
Signed-off-by: see-quick <[email protected]>
@see-quick
update Lukas review
fda5625 
Signed-off-by: see-quick <[email protected]>
@see-quick
updated node pools to KafkaNodePools
d9f1517 
Signed-off-by: see-quick <[email protected]>
@see-quick
make it more consistent
9af2a87 
Signed-off-by: see-quick <[email protected]>
@see-quick
review from Jakub more consistency added
68db5bf 
Signed-off-by: see-quick <[email protected]>

# Conflicts:
#	systemtest/src/test/java/io/strimzi/systemtest/rollingupdate/KafkaRollerST.java
@see-quick
a few updates
1ef290c 
Signed-off-by: see-quick <[email protected]>
@see-quick
update Lukas review
9f1d183 
Signed-off-by: see-quick <[email protected]>
@see-quick
move CO to capitals
92ca96a 
Signed-off-by: see-quick <[email protected]>
henryZrncik
henryZrncik approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@henryZrncik henryZrncik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Frawless
Frawless reviewed Oct 8, 2024
View reviewed changes
systemtest/src/test/java/io/strimzi/systemtest/kafka/ConfigProviderST.java Outdated
Comment on lines 68 to 69
@Step(value = "Create necessary Role and RoleBinding for connector.", expected = "Role and RoleBinding are created and applied."),
@Step(value = "Deploy Kafka connector.", expected = "Kafka connector is successfully deployed."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then why this file has old formating?

@see-quick
Jakub review
38aa0cc 
Signed-off-by: see-quick <[email protected]>
@see-quick see-quick merged commit b56b770 into strimzi:main Oct 11, 2024
13 checks passed
@scholzj scholzj mentioned this pull request Oct 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frawless Frawless Frawless left review comments

@henryZrncik henryZrncik henryZrncik approved these changes

@PaulRMellor PaulRMellor PaulRMellor approved these changes

@im-konge im-konge im-konge approved these changes

@jankalinic jankalinic jankalinic approved these changes

Assignees

@see-quick see-quick

Labels
System tests
Projects
None yet
Milestone
0.44.0
Development

Successfully merging this pull request may close these issues.
6 participants
@see-quick @Frawless @henryZrncik @PaulRMellor @im-konge @jankalinic