Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ContainerEnvVar class to the template subpackage #10628

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Sep 23, 2024

Type of change

  • Refactoring

Description

The ContainerEnvVar class was for some reason outside of the template subpackage although it was used only in templates. This PR moves it there. It also addresses the left over comment from #10623.

Checklist

  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

@scholzj scholzj added this to the 0.44.0 milestone Sep 23, 2024
@scholzj scholzj requested a review from a team September 23, 2024 16:05
@scholzj scholzj changed the title Move ContinerEnvVar class to the template subpackage Move ContainerEnvVar class to the template subpackage Sep 23, 2024
@scholzj
Copy link
Member Author

scholzj commented Sep 23, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj merged commit dd48ff1 into strimzi:main Sep 24, 2024
21 checks passed
@scholzj scholzj deleted the move-ContainerEnvVar-to-template-package branch September 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants