Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate methods in Connect operators #10604

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Remove duplicate methods in Connect operators #10604

merged 1 commit into from
Sep 20, 2024

Conversation

katheris
Copy link
Contributor

@katheris katheris commented Sep 18, 2024 •
edited
Loading

Type of change

Select the type of your PR

  • Refactoring

Description

  • Remove duplicate methods from KafkaConnectAssemblyOperator and KafkaMirrorMaker2AssemblyOperator classes.
  • Rename methods in KafkaMirrorMaker2AssemblyOperator so reconcileConnectors method name is not overloaded.
  • Clean up use of vert.x Futures.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@katheris
Remove duplicate methods in Connect operators
2bf67bf 
* Remove duplicate methods from KafkaConnectAssemblyOperator and KafkaMirrorMaker2AssemblyOperator classes.
* Rename methods in KafkaMirrorMaker2AssemblyOperator so
reconcileConnectors method name is not overloaded.
* Clean up use of vert.x Futures.

Signed-off-by: Katherine Stanley <[email protected]>
@scholzj scholzj added this to the 0.44.0 milestone Sep 18, 2024
@scholzj
Copy link
Member

scholzj commented Sep 18, 2024

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@katheris katheris marked this pull request as ready for review September 19, 2024 11:35
@katheris katheris requested review from scholzj and a team September 19, 2024 11:36
@scholzj scholzj requested a review from ppatierno September 19, 2024 12:51
scholzj
scholzj reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katheris

scholzj
scholzj approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I wanted to approve it and not just thank you 🤦.

ppatierno
ppatierno approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@scholzj scholzj merged commit 0c7601a into strimzi:main Sep 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

@see-quick see-quick see-quick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.44.0
Development

Successfully merging this pull request may close these issues.
4 participants
@katheris @scholzj @ppatierno @see-quick