[ST] upgrade downgrade STs namespaces creation/deletion minor fix #10568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hzrncik <[email protected]>
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
henryZrncik
changed the title
see-quick
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM, just a one question 👍 Good job @henryZrncik and thanks!
systemtest/src/test/java/io/strimzi/systemtest/upgrade/AbstractUpgradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/AbstractUpgradeST.java
Outdated
Show resolved
Hide resolved
im-konge
approved these changes
Sep 13, 2024
Signed-off-by: hzrncik <[email protected]>
henryZrncik
added
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
create helper methods for namespace deletion creation in AbstractUpgradeST to be available on demand use in other Upgrade system tests (as there is a little bit logic so to follow DRY principle).
Fix creation of namesapces in *UpgradeDowngradeST, formerly the namespace was created only once so when test-suite-ns was introduced the test would fail on namespace actually not existing originally.