[ST] Use the KafkaConnect with Connector upgrade/downgrade scenario as the main one #10544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…t new default Signed-off-by: Lukas Kral <[email protected]> upgrade also kafka version in the KafkaConnect Signed-off-by: Lukas Kral <[email protected]> update continuousClientsMessage Signed-off-by: Lukas Kral <[email protected]> add set LMFV to null in other test cases as well Signed-off-by: Lukas Kral <[email protected]>
im-konge
force-pushed
the
connect-upgrade
branch
2 times, most recently
from
9bf80a7 to
2777f5a
Compare
Signed-off-by: Lukas Kral <[email protected]>
im-konge
force-pushed
the
connect-upgrade
branch
from
2777f5a to
aa99595
Compare
|
/azp list |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
approved these changes
Sep 6, 2024
Signed-off-by: Lukas Kral <[email protected]>
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lukas Kral <[email protected]>
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR updates the upgrade/downgrade scenarios to run the parametrized tests together with Connect and the KafkaConnector resources.
Until now, we had first upgrade/downgrade scenarios that took the testcases from particular YAML files (with FG and other stuff) that checked upgrade of Strimzi just with Kafka cluster. Then, we have other scenarios with just Kafka cluster (like upgrading with unsupported Kafka version or empty version etc.). And finally, there is scenario for upgrade/downgrade of Strimzi with Kafka and KafkaConnect + KafkaConnector. The issue is that for example for downgrade, the logic is to pick the version from the BundleDowngrade.yaml, where we have FGs (same for upgrade IIRC). So in case that there are no scenarios with FGs, it's skipped or it ends up in error.
Because the scenario is more or less (the Kafka cluster upgrade/downgrade part) covered in the parametrized test, the KafkaConnect + KafkaConnector scenario adds value just in the KafkaConnect case.
To save some time and test exactly the same thing, it's better to "remove" the scenario just with Kafka cluster upgrade/downgrade, and add the scenario with Kafka + KafkaConnect + KafkaConnector. Thanks to that, the test scenario will be wider, we will test more and also save some time (and the KafkaConnect scenario will not be fixed).
The PR updates the code to handle this kind of upgrade/downgrade, adds possibility to also upgrade the KafkaConnect's Kafka version inside the KafkaConnect's
.spec.versionfield, removes not needed methods (which were used for the previous parametrized tests), changes the parametrized name of the tests (downgrade ones), and bumps the number of messages that should be sent/received throughout the test.Checklist