Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run AZP in KRaft mode and create ZK regression pipeline #10532

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Sep 3, 2024

Type of change

  • Enhancement

Description

This PR changes the default mode in which we are running AZP.
It:

  • changes the default mode to KRaft
  • creates the zookeeper-regression pipeline, which runs without KRaft and NodePools
  • changes the default of the STRIMZI_USE_KRAFT_IN_TESTS environment variable to true

From now on, when we run STs, they will be run in KRaft mode. In order to test ZK mode in AZP, we will need to run the zookeeper-regression pipeline.

Checklist

  • Make sure all tests pass

@im-konge im-konge added this to the 0.44.0 milestone Sep 3, 2024
@im-konge im-konge self-assigned this Sep 3, 2024
@im-konge im-konge requested a review from a team September 3, 2024 13:32
@im-konge im-konge changed the title Run AZP in KRaft mode, remove kraft-regression pipeline and create ZK regression pipeline Run AZP in KRaft mode and create ZK regression pipeline Sep 3, 2024
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aassuming it works. Thanks.

What impact does this have at Acceptance, Helm Acceptance, Bridge, Migration, and Upgrade pipelines? I assume it switches the first three to KRaft as well, which is IMHO fine. But we should make sure the later two keep working properly as well.

@scholzj
Copy link
Member

scholzj commented Sep 3, 2024

Also, I guess you should have opened the PR from a branch directly in the Strimzi repo as you probably cannot really test it now?

@im-konge
Copy link
Member Author

im-konge commented Sep 3, 2024

I can't, I tried to include it on my repository
But I can push to Strimzi repo directly and from there create the pipeline and run the tests here.

What impact does this have at Acceptance, Helm Acceptance, Bridge, Migration, and Upgrade pipelines?

Everything will by default run in KRaft. The Upgrade pipeline is not that much affected, as each suite runs it's own mode -> the regular StrimziUpgrade/DowngradeST (KafkaUpgradeDowngradeST included) are running in ZK mode, KRaft...ST in KRaft. The MigrationST is skipped if the NodePools and KRaft are not enabled, which is not the case and it will not have any influence on running the ST. I can run it here and see if it's okay.

@im-konge
Copy link
Member Author

im-konge commented Sep 3, 2024

/azp list

@im-konge
Copy link
Member Author

im-konge commented Sep 3, 2024

/azp run zookeeper-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Sep 4, 2024

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Sep 4, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Sep 4, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Sep 4, 2024

/azp run upgrade

Copy link

Pull request contains merge conflicts.

…te ZK regression pipeline

Signed-off-by: Lukas Kral <[email protected]>

bring back kraft-regression

Signed-off-by: Lukas Kral <[email protected]>

upgrade/downgrade fixup

Signed-off-by: Lukas Kral <[email protected]>

change upgrade to work on KRaft enabled

Signed-off-by: Lukas Kral <[email protected]>
@im-konge
Copy link
Member Author

im-konge commented Sep 5, 2024

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Sep 5, 2024

/azp list

@im-konge
Copy link
Member Author

im-konge commented Sep 5, 2024

/azp run helm-acceptance

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge
Copy link
Member Author

im-konge commented Sep 5, 2024

/azp run feature-gates-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge im-konge merged commit 8243ea4 into strimzi:main Sep 6, 2024
35 checks passed
@im-konge im-konge deleted the zk-regression branch September 6, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants