-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run AZP in KRaft mode and create ZK regression pipeline #10532
Conversation
30334e1
to
b3bf857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aassuming it works. Thanks.
What impact does this have at Acceptance, Helm Acceptance, Bridge, Migration, and Upgrade pipelines? I assume it switches the first three to KRaft as well, which is IMHO fine. But we should make sure the later two keep working properly as well.
Also, I guess you should have opened the PR from a branch directly in the Strimzi repo as you probably cannot really test it now? |
I can't, I tried to include it on my repository
Everything will by default run in KRaft. The Upgrade pipeline is not that much affected, as each suite runs it's own mode -> the regular StrimziUpgrade/DowngradeST (KafkaUpgradeDowngradeST included) are running in ZK mode, KRaft...ST in KRaft. The MigrationST is skipped if the NodePools and KRaft are not enabled, which is not the case and it will not have any influence on running the ST. I can run it here and see if it's okay. |
/azp list |
/azp run zookeeper-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run migration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Pull request contains merge conflicts. |
…te ZK regression pipeline Signed-off-by: Lukas Kral <[email protected]> bring back kraft-regression Signed-off-by: Lukas Kral <[email protected]> upgrade/downgrade fixup Signed-off-by: Lukas Kral <[email protected]> change upgrade to work on KRaft enabled Signed-off-by: Lukas Kral <[email protected]>
398e35c
to
81c067c
Compare
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp list |
/azp run helm-acceptance |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run feature-gates-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
Type of change
Description
This PR changes the default mode in which we are running AZP.
It:
zookeeper-regression
pipeline, which runs without KRaft and NodePoolsSTRIMZI_USE_KRAFT_IN_TESTS
environment variable totrue
From now on, when we run STs, they will be run in KRaft mode. In order to test ZK mode in AZP, we will need to run the
zookeeper-regression
pipeline.Checklist