Use LockSupport.parkNanos instead of Thread.sleep in systemtests #10522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Kornel <[email protected]>
|
/packit test --labels regression |
kornys
changed the title
im-konge
approved these changes
Aug 30, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Sep 2, 2024
Frawless
approved these changes
Sep 3, 2024
|
Maybe the description should explain why it is being done? |
done |
scholzj
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Use LockSupport.parkNanos instead of Thread.sleep when we need to wait in systemtests.
The use of LockSupport.parkNanos is more consistent with modern concurrency practices in Java, where fine-grained control over thread states is often required. This change aligns the codebase with best practices for implementing efficient concurrency mechanisms.
Unlike Thread.sleep, LockSupport.parkNanos does not throw an InterruptedException but instead returns immediately if the thread is interrupted.
And also my IDE does not warn me with Thread.sleep :D
Checklist