-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase minio secret key length for FIPS #10518
Conversation
Signed-off-by: Luke Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I guess that the issue in Aiven Tiered Storage plugin should be closed?
/azp run build |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
No, I'd like to test FIPS support in real AWS S3. Will leave comment in the Aiven's issue when completed. |
OK, I've confirmed the openshift cluster with FIPS enabled can upload log segment to AWS S3, and read from S3 without error. I'll leave a comment in the Aiven's issue. Thanks. |
@showuon thanks a lot for the investigation and fixup! 🙂 |
Type of change
Select the type of your PR
Description
We disabled FIPS test for tiered storage system test because of the issue: Aiven-Open/tiered-storage-for-apache-kafka#573 . After investigation, I found it's because the secret key length we set is too short, which is not compatible with FIPS compliance. After increasing the secret key size, the test passes.
Checklist
Please go through this checklist and make sure all applicable tasks have been done