Improve handling of invalid topic configurations #10517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvaleri
force-pushed
the
to-null-config
branch
2 times, most recently
from
b93b1b2 to
d294c0f
Compare
ShubhamRwt
approved these changes
Aug 29, 2024
ShubhamRwt
reviewed
Aug 29, 2024
topic-operator/src/main/java/io/strimzi/operator/topic/BatchingTopicController.java
Show resolved
Hide resolved
|
/packit test --labels regression |
|
@fvaleri I pushed a few tweaks to your branch. Could you take a look and let me know if you agree with them, if not we can discuss here. Thanks. |
An invalid topic configuration results in a RuntimeException that fails the whole reconciliation and following periodic reconciliations. Additionally, if you have a batch of 100 topics or more, it can be difficult to spot where the configuration errors is. With this change the TO reports the error in the status of the Kafka topic containing the invalid configuration, and continues with the reconciliation. Signed-off-by: Federico Valeri <[email protected]>
1. Propagate null config value to Kafka as a special case. This an an improvement because the TO generally takes the position that validation of configs should be done my Kafka, not the operator, which allows Kafka to change what's considered valid without needing to update the TO. 2. I figured out that we can pass values of other JSON types as well as null, so I added a test for this. 3. For such types configValueAsString() must return a String, but there's no corresponding ConfigDef.Type, so configValueAsString() must throw something. But let's use something more specific than RuntimeException. Signed-off-by: Tom Bentley <[email protected]>
fvaleri
force-pushed
the
to-null-config
branch
from
7a6a7fb to
a58e9a5
Compare
|
Thanks for the improvement. It looks good, I just did a rebase due to an import conflict. We are good to go now. |
Signed-off-by: Federico Valeri <[email protected]>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Improvement
Description
An invalid topic configuration results in a RuntimeException that fails the whole reconciliation and following periodic reconciliations. Additionally, if you have a batch of 100 topics or more, it can be difficult to spot where the configuration errors is.
With this change the TO reports the error in the status of the Kafka topic containing the invalid configuration, and continues with the reconciliation.
Checklist