Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 11 of unit tests update for KRaft #10499

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 26, 2024

Step x

Type of change

  • Task

Description

This is the part 11 of the unit test refactoring to better support KRaft. This part focuses on the KafkaClusterTest class. It does the following changes:

  • The KafkaClusterPodSetTest with StrimziPodSet-based unit tests was merged into the KafkaClusterTest (we anyway don't have any StatefulSet tests anymore anyway, which was the purpose of the separation)
  • The original ZooKeeper-based tests are kept in KafkaClusterZooBasedTest.
  • The KafkaClusterTest was rewritten to KRaft and to make it smaller, it was split into three classes:
    • KafkaClusterTest with most of the tests
    • KafkaClusterListenersTest with the tests focused on the listeners
    • KafkaClusterStorageTest with the tests arounf storage

Checklist

  • Write tests
  • Make sure all tests pass

Signed-off-by: Jakub Scholz <[email protected]>

Step x

Signed-off-by: Jakub Scholz <[email protected]>
@scholzj scholzj added this to the 0.44.0 milestone Aug 26, 2024
@scholzj scholzj requested a review from a team August 26, 2024 21:12
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scholzj scholzj merged commit 3ee088e into strimzi:main Aug 27, 2024
13 checks passed
@scholzj scholzj deleted the wave-11-of-KRaft-unit-test-updates branch August 27, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants