Add Topic Operator refactoring: handlers #10412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tombentley
reviewed
Aug 20, 2024
topic-operator/src/main/java/io/strimzi/operator/topic/model/Results.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/model/TopicOperatorException.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/model/Results.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/model/Results.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/model/Results.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/cruisecontrol/CruiseControlHandler.java
Outdated
Show resolved
Hide resolved
...-operator/src/main/java/io/strimzi/operator/topic/cruisecontrol/CruiseControlClientImpl.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/KubernetesHandler.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/KubernetesHandler.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/KubernetesHandler.java
Show resolved
Hide resolved
tombentley
reviewed
Aug 21, 2024
topic-operator/src/main/java/io/strimzi/operator/topic/model/Results.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/model/TopicOperatorException.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/model/Results.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/model/Results.java
Outdated
Show resolved
Hide resolved
topic-operator/src/main/java/io/strimzi/operator/topic/cruisecontrol/CruiseControlHandler.java
Show resolved
Hide resolved
fvaleri
force-pushed
the
to-ref-btc
branch
2 times, most recently
from
757ae49 to
3b07dc3
Compare
|
@tombentley hopefully, I addressed all your comments, including the ascii art one :) Failed test is unrelated. |
|
/packit test --labels regression |
fvaleri
force-pushed
the
to-ref-btc
branch
3 times, most recently
from
b19b588 to
2a595be
Compare
This change completes the TO refactoring by introducing a set of handlers and related tests. Each handler contains the logic used to call an external system, and helps to keep the BatchTopicController focused on the reconciliation logic. This also introduces the Results object, used toeliminate all side effects from reconciliation functions. The fix for strimzi#9972 is also included. All unit, integration and relevant system tests have been run locally. Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
|
/packit test --labels regression |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run build |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This change completes the TO refactoring by introducing a set of handlers and related tests. Each handler contains the logic used to call an external system, and helps to keep the BatchTopicController focused on the reconciliation logic. This also introduces the Results object, used toeliminate all side effects from reconciliation functions.
The fix for #9972 is also included.
All unit, integration and relevant system tests have been run locally.
Checklist