Fix flaky TopicReplicasChangeST#testKafkaTopicReplicaChangePositiveRoundTrip #10339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/packit test --labels regression |
|
As a side effect, all CC tests should become faster if this works. |
|
What does this have to do with |
Yes, sorry, let me fix it. Working on too many flaky tests :D |
fvaleri
changed the title
fvaleri
changed the title
…undTrip This change is an attempt to fix the flaky TopicReplicasChangeST#testKafkaTopicReplicaChangePositiveRoundTrip. Looking at logs I can confirm that the timeout is indeed due to the Cruise Control's cluster model not being ready in time. The Cruise Control setup proposed here seems to make the cluster model generation faster. It basically reduces the partition/replica count of Cruise Control's topics and the metrics window. On my machine, the whole test suite went down from 26 minutes to 13 minutes, which is a 50% improvement. It would be good if someone else could confirm that by running TopicReplicasChangeST before and after this change. With this change, I wasn't able to trigger the issue locally after many runs. I would suggest to run regression tests 2 or 3 times to confirm this really helps. Signed-off-by: Federico Valeri <[email protected]>
fvaleri
changed the title
fvaleri
force-pushed
the
flaky-positive-trip
branch
from
a7ca402 to
7206661
Compare
Signed-off-by: Federico Valeri <[email protected]>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/packit test --labels regression |
|
Looks like it worked. Wdyt? |
|
The results are good, 1 flake on azure, not sure if it could be somehow connected or could be improved |
Frawless
reviewed
Jul 16, 2024
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaTemplates.java
Show resolved
Hide resolved
Signed-off-by: Federico Valeri <[email protected]>
Frawless
approved these changes
Jul 16, 2024
|
@kyguy @ppatierno are you good with these changes? |
ppatierno
reviewed
Jul 17, 2024
systemtest/src/main/java/io/strimzi/systemtest/templates/crd/KafkaTemplates.java
Show resolved
Hide resolved
ppatierno
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This change is an attempt to fix the flaky
TopicReplicasChangeST.testKafkaTopicReplicaChangePositiveRoundTrip. Looking at logs I can confirm that the timeout is indeed due to the Cruise Control's cluster model not being ready in time.The Cruise Control setup proposed here seems to make the cluster model generation faster. It basically reduces the partition/replica count of Cruise Control's topics and the metrics window. On my machine, the whole test suite went down from 26 minutes to 13 minutes, which is a 50% improvement. It would be good if someone else could confirm that by running
TopicReplicasChangeSTbefore and after this change.With this change, I wasn't able to trigger the issue locally after many runs. I would suggest to run regression tests 2 or 3 times to confirm this really helps.
Should fix #10295.
Checklist