Fix the Helm Chart release pipeline to ignore the state of container push with suffix #10298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…push with suffix Signed-off-by: Jakub Scholz <[email protected]>
Frawless
approved these changes
Jul 4, 2024
see-quick
approved these changes
Jul 4, 2024
scholzj
added a commit
that referenced
this pull request
Jul 8, 2024
…push with suffix (#10298) Signed-off-by: Jakub Scholz <[email protected]>
mstruk
pushed a commit
to mstruk/strimzi-kafka-operator
that referenced
this pull request
Jul 15, 2024
…push with suffix (strimzi#10298) Signed-off-by: Jakub Scholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In #10112, we reordered the release pipeline to push the Helm Chart to the OCI registry only at the end. But we kept the condition as
succeeded()which means that it is run when all previous steps ended asSucceededorSucceededWithIssues. So when we run the release pipeline with for an RC and thecontainers_publish_with_suffixstage is skipped, the Helm Chart is not pushed to the OCI registry. This PR should address it by linking the condition only to the result of thecontainers_publishstage instead of usingsucceeding()and fix the dependency issue.