Make sure Helm Unit tests work even for releases #10291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <[email protected]>
|
CC @maciej-tatarski - can you please have a look? Thanks. |
im-konge
approved these changes
Jul 1, 2024
Frawless
approved these changes
Jul 2, 2024
see-quick
approved these changes
Jul 2, 2024
scholzj
added a commit
that referenced
this pull request
Jul 8, 2024
Signed-off-by: Jakub Scholz <[email protected]>
mstruk
pushed a commit
to mstruk/strimzi-kafka-operator
that referenced
this pull request
Jul 15, 2024
Signed-off-by: Jakub Scholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The Helm Chart unit tests currently don't work in releases because they have hardcoded
:latestversion for container images. This PR updates the tests to use a regex that either accepts:latestor a particular version such as0.42.0. This should allow the tests to pass.Checklist