-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NodeIds in KafkaNodePool printer columns #10287
Add NodeIds in KafkaNodePool printer columns #10287
Conversation
ca4b89f
to
435b775
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea seems reasonable assuming it works. But in any case, you would need to build the project to generate the new CRD definitions and not just modify the Java class.
435b775
to
d05c98b
Compare
Hey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to do the change tot he CRD also in the packaging/helm/...
directory. You can run the make crd_install
command to copy it out.
Signed-off-by: Vincent Chenal <[email protected]>
d05c98b
to
6205af6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
/azp run acceptance |
Azure Pipelines successfully started running 1 pipeline(s). |
I was able to finally run the tests (acceptance+integration), which are running fine locally 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My only concern could be how much the console output will be easily screwed up with a cluster having i.e. 50 brokers and even not using an IDs range from 0 to 49 but i.e. starting from 1000 (just for having more digits). Anyway unless someone will complain, I think it's a nice to have. Thanks for the contribution!
Thanks for the PR. |
Type of change
Description
Add a new printer column for KafkaNodePool objects: NodeIds.
Checklist