[helm] add kafkanodepools to RBAC AggregateRoles #10275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Horacio Granillo <[email protected]>
|
Thank you guys, strimzi is amazing ❤️ |
|
/azp run helm-acceptance |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adds missing kafkanodepools to the Aggregation roles view and admin.
For the view role I've used https://github.com/strimzi/strimzi-kafka-operator/blob/main/install/strimzi-admin/010-ClusterRole-strimzi-admin.yaml#L15 as reference
and https://github.com/strimzi/strimzi-kafka-operator/blob/main/install/strimzi-admin/010-ClusterRole-strimzi-admin.yaml#L15 and https://github.com/strimzi/strimzi-kafka-operator/blob/main/install/strimzi-admin/010-ClusterRole-strimzi-admin.yaml#L35 as reference for the admin role
Checklist