Fix TO-CC race condition issue happening during throttled rebalances #10241
Conversation
|
Isn't there another PR for this? #10182? Also, it would be great if you could bother and write some description about what the PR does and how! |
The bug has been opened for 2 months, and it's 3 weeks I haven't heard from the contributor after multiple pings. Additionally, in the last community meeting we agreed to ping the contributor one more time and wait an additional week, which has passed.
Description is here, but I can also add in the description if you prefer. |
Then maybe some maintainer should deal with the original PR first, before you open another one.
Yes, please update the description! Each PR should have a description explaining what it does and how. It should be something to do automatically, you have been asked again and again by different people to do it. And it would be great if you could start using the provided template. There is a reason why the template is there and it should be followed. |
@scholzj that could have been my fault. As @fvaleri said we agreed to ping the contributor one more time during the last community call and it was something already done by Federico a couple of times. I just said him to open the PR but didn't think to ping (again!??) the contributor. I thought it was already enough because he didn't come back to us since 2-3 weeks. |
This change fixes the issue caused by the TO-CC race condition happening during throttled rebalances. The TO reverts dynamic throttled configs set by CC at the topic level because they don't match with the KT spec. A private constant that contains the two throttle config properties is added to the BatchingTopiController, along with the following logic: - If Cruise Control is enabled WITHOUT .spec.config throttle props, we skip any throttle alter config operation without warnings - If Cruise Control is enabled WITH .spec.config throttle props, we do not skip the throttle alter config operations, but we raise a warning (can't be an error because there is no race when running rebalances without throttling, which is the default) - If Cruise Control is NOT enabled, we reconcile as usual without warnings The interaction between ALTERABLE_TOPIC_CONFIG and THROTTLING_CONFIG is covered by the new unit tests. Fixes strimzi#9972. Signed-off-by: Federico Valeri <[email protected]>
topic-operator/src/main/java/io/strimzi/operator/topic/BatchingTopicController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Federico Valeri <[email protected]>
|
@strimzi/maintainers can you start regression tests? Thanks |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tombentley should be good now. |
|
I will open a new PR based on some refactoring we are doing. The fix is currently hosted in #10248. |
This change fixes the issue caused by the TO-CC race condition during throttled rebalances. The TO reverts dynamic throttled configs set by CC at the topic level because they don't match with the KT spec.
A private constant that contains the two throttle config properties is added to the BatchingTopiController, along with the following logic:
The interaction between ALTERABLE_TOPIC_CONFIG and THROTTLING_CONFIG is covered by the new unit tests.
Fixes #9972.