-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote the UseKRaft feature gate to GA #10106
Promote the UseKRaft feature gate to GA #10106
Conversation
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run migration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run kraft-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
/azp run feature-gates-regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
4290421
to
d3ec232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good. Just a couple of minor suggestions.
...rator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KafkaAssemblyOperator.java
Outdated
Show resolved
Hide resolved
...t/java/io/strimzi/operator/cluster/operator/assembly/KafkaAssemblyOperatorWithKRaftTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <[email protected]>
Type of change
Description
In line with the Strimzi Proposal 62, this PR moves the
UseKRaft
to GA. It removes it from the code and keeps it permanently enabled.Note: This does not mean KRaft is used by default as it still needs to be enabled with the
strimzi.io/kraft: enabled
feature gate. There is just no feature gate anymore.There are two tasks that might be done in separate PRs as follow-ups:
FeatureGatesST
class seems useful, but not sure it makes sense to keep it in the Feature Gates testsChecklist