-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for the released files #66
Conversation
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the indentation in the Makefile.os is wrong, but otherwise looks good to me
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you actually test the changes? I do not seem to see that in the uild logs.
./.azure/scripts/release_files_check.sh
checksum of ./install matches expected checksum => OK
checksum of ./examples matches expected checksum => OK Hmm? |
Well, you should test that it actually fails when some changes are in the files. So change something in examples and install, commit and push it => see that it fails. And then once you confirm it you can revert it again. |
I mean this I tested locally, but if you want it that way sure. I can do it |
Signed-off-by: see-quick <[email protected]>
works now I will revert it. |
Signed-off-by: see-quick <[email protected]>
Now you can test it for the installation files as well :-) |
Signed-off-by: see-quick <[email protected]>
I guess you can think a bit about the output as well?
The last part does not make sense ... you do not need to change the |
Signed-off-by: see-quick <[email protected]>
Yeah true last part is no needed. Updated to
|
Signed-off-by: see-quick <[email protected]>
Co-authored-by: Jakub Scholz <[email protected]> Signed-off-by: Maros Orsak <[email protected]>
Co-authored-by: Jakub Scholz <[email protected]> Signed-off-by: Maros Orsak <[email protected]>
I can also update the operator repo after we merge this PR. |
Signed-off-by: see-quick <[email protected]> Signed-off-by: Maros Orsak <[email protected]> Co-authored-by: Jakub Scholz <[email protected]>
This PR adds a check for released files. So if anyone changes the content of examples/, install/ or helm/charts instead of packaging then CI would throw an error.
Note: Currently we do not have a helm-charts directory because such a feature was implemented recently, so I have added TODO: after we release and then we could also include this check.
Solves #59.