Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Nullable and Modernization for Stride.Core. & Stride.Core.AssemblyProcessor #2639

Merged
merged 18 commits into from
Feb 15, 2025

Conversation

Kryptos-FR
Copy link
Member

@Kryptos-FR Kryptos-FR commented Feb 14, 2025

PR Details

In the same spirit of #2266, modernize Stride.Core and Stride.Core.AssemblyProcessor.

Description

  1. Enable nullable on both projects.
  2. Use new language features such as collection initialization, pattern matching, range and indexers, etc.
  3. Enable implicit usings, and use file-scoped namespaces.

Related Issue

#2155
#2156

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR Kryptos-FR added the area-Core Issue of the engine unrelated to other defined areas label Feb 14, 2025
@Kryptos-FR Kryptos-FR marked this pull request as ready for review February 14, 2025 21:21
@Kryptos-FR Kryptos-FR force-pushed the feature/nullable-annotations branch 2 times, most recently from 194a3e1 to e9f1ecc Compare February 14, 2025 21:34
@Kryptos-FR Kryptos-FR force-pushed the feature/nullable-annotations branch from a788dc4 to aac8afb Compare February 15, 2025 22:46
@Eideren Eideren merged commit 44f4ff6 into stride3d:master Feb 15, 2025
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Feb 15, 2025

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Core Issue of the engine unrelated to other defined areas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants