assert: Fail Subset/NotSubset when a map superset is missing elements
#1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a subset map contains an item with a key that is not present in the superset map, attempts to reflect the interface of the value at the absent key cause panics, which return false on recovery but do not properly fail the test with a message. This also aligns the `Subset` failure message with the corresponding `NotSubset` failure message.
dolmen
added
bug
pkg-assert
|
Duplicate of #1261 |
|
Thank you for your efforts, I can confirm this was fixed in the other PR, it's no longer a problem on v1.8.4 (latest) or on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid panics in
assert.Subset/assert.NotSubsetand properly fail the test when a superset map is missing elements from the subset map.Changes
subsetKeyof the superset reflectionlistValue.isValid, before attempting to get its interface value for use inObjectsAreEqualassertion.Subsetfailure message with the correspondingNotSubsetfailure message.Motivation
When a subset map contains an item with a key that is not present in the superset map, attempts to reflect the interface of the value at the absent key cause panics, which return
falseon recovery but do not properly fail the test with a message.Related issues
Closes #1270