Codeclimate (#54)

* Remove untested check * Remove New() call * Ingore more files for codeclimate
stretchr · Jan 28, 2018 · cfebd64 · cfebd64
1 parent 84b0369
commit cfebd64
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/.codeclimate.yml b/.codeclimate.yml
@@ -10,4 +10,9 @@ exclude_patterns:
 - ".github/"
 - "vendor/"
 - "codegen/"
+- "*.yml"
+- "*.md"
+- "Gopkg.*"
 - "doc.go"
+- ".gitignore"
+- "LICENSE"
diff --git a/conversions.go b/conversions.go
@@ -40,10 +40,7 @@ func (m Map) Base64() (string, error) {
 	}
 
 	encoder := base64.NewEncoder(base64.StdEncoding, &buf)
-	_, err = encoder.Write([]byte(jsonData))
-	if err != nil {
-		return "", err
-	}
+	_, _ = encoder.Write([]byte(jsonData))
 	_ = encoder.Close()
 
 	return buf.String(), nil

diff --git a/map.go b/map.go
@@ -97,12 +97,12 @@ func MustFromJSON(jsonString string) Map {
 //
 // Returns an error if the JSON is invalid.
 func FromJSON(jsonString string) (Map, error) {
-	var data interface{}
+	var data Map
 	err := json.Unmarshal([]byte(jsonString), &data)
 	if err != nil {
 		return Nil, err
 	}
-	return New(data), nil
+	return data, nil
 }
 
 // FromBase64 creates a new Obj containing the data specified