-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
0773e91
to
d418611
Compare
Thank you for your proposal! While I think that the addition to the readme makes perfectly sense, I don't really think that it is necessary to add another hint in the style files as there is already a hint where all constants/global variables are defined: streetcomplete-mapstyle/global.yaml Lines 1 to 2 in 59fbc4d
After all, the website at https://streetcomplete.github.io/streetcomplete-mapstyle/ offers more or less the same functionality to edit a style (via the pencil icon in the top left corner) even without requiring to use an API key. Was it difficult for you to figure out how to edit the styles? |
It took my a while to figure it out for Tangram Play. I only discovered the link to https://streetcomplete.github.io/streetcomplete-mapstyle/, after I already setup Tangram Play with the API key. Maybe this should be the prefered way of editing for the Contributing section in the readme with an annotation that it doesn't need an API key for jawg.io. What do you think about that? |
Your suggestion sounds great! Would you like to modify this PR to implement this suggestion? https://streetcomplete.github.io/streetcomplete-mapstyle/?provider=jawg&style=light
https://streetcomplete.github.io/streetcomplete-mapstyle/?provider=jawg&style=dark
https://streetcomplete.github.io/streetcomplete-mapstyle/?provider=jawg&style=satellite |
d418611
to
6f62c9d
Compare
Add hint to add jawg.io API key when using Tangram Play.
6f62c9d
to
410ac30
Compare
@ENT8R updated the PR. Can you take another look, please? |
Co-authored-by: ENT8R <[email protected]>
It's better if the default changes later. Co-authored-by: ENT8R <[email protected]>
@ENT8R thanks for catching the error and the suggested improvement. I implemented your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I somehow forgot about this PR, thank you for bringing it back to my attention
This makes it more obvious that the API key needs to be provided when using Tangram Play. See also the instructions provided at #87 (comment).