Display bridges and piers

[Helium314]

fixes #86 and #101

Bridge structures and piers are now displayed with the same color as buildings.

Order is higher than water/landuse and lower than anything else. This means bridges are displayed below ways that actually go under the bridge. Not really nice, but same as in standard style on openstreetmap.org.

[westnordost]

Or maybe use earth_color?

[Helium314]

Maybe... I didn't play around too much with the color. I'll check how it looks.

[Helium314]

building_color:

earth_color

building_outline_color

[Helium314]

I also had a look at dark style, and personally I like building_outline_color most in both themes.

[westnordost]

I think I slightly favour the reddish landuse-color but if you favour the building outline color, that would also be fine.

[Helium314]

I'd prefer some color that is not on used for background, because it may look confusing if bridge looks like the area below.
E.g. with earth_color it could be confused with some sort of dam, while a building / building outline color makes it more look like a building.

[Joxit]

I'm glad that you added bridges 😁

FYI this is how we render bridges https://maps.jawg.io/#17.94/43.492481/-1.474054

[mnalis]

Was this supposed to render man_made=pier too? Because in SC 45.2 (f-droid) it still doesn't.
For example here is man_made=pier made years ago: https://www.openstreetmap.org/note/3197913#map=19/43.73060/15.80269&layers=N

And it is still not shown in SC 45.2:

[Helium314]

It should render, and does work for me

[mnalis]

It should render, and does work for me

Huh, did you try at that specific location or somewhere else? Maybe it has some other tags too at place where you tried?

I don't see this one (https://www.openstreetmap.org/way/360995691) on either of my phones (android 10 and android 6), neither on SC 45.2, 45.2EE, nor 46.0 😢 - as picture above shows. Same issue with dark and light themes.

I don't see other piers either (even when I uninstalled and reinstalled SC, so it shouldn't be stale cache issue).
E.g. https://www.openstreetmap.org/way/293594752, https://www.openstreetmap.org/way/598082067 etc.

[Helium314]

They are not closed ways, and this PR only contains draw for polygons.
You can try adding same thing for lines and see whether it works.