This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously village and town could have the same scalerank, with unimportant label obscuring more important
also, water label could obscure town label (at least theoretically)
fixes #113
The open questions:
is it necessary to do the same for other map branches? Probably not worth time for investigating is similar poor ordering present also there
it is possible to apply the very similar solution for having different label sizes (and actually I used it for debugging)
I plan on merging it after one extra testing round (when I am less sleepy) and after giving people time for checking it, but I am quite certain about this
note: to make testing easier label size can be bumped, for example with