Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual names for brand features; don't show "has no name" option for features with fixed name #6100

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

westnordost
Copy link
Member

respect preserveTags property in osmfeatures (fixes #6086, fixes #5985)

@westnordost westnordost requested a review from mnalis January 15, 2025 20:06
@mnalis
Copy link
Member

mnalis commented Jan 18, 2025

Um, what problems is it supposed to fix exactly? I've tried compiling that branch at bbf233d (at https://github.com/mnalis/StreetComplete/actions/runs/12810652342) and:

@mnalis
Copy link
Member

mnalis commented Jan 18, 2025

small_Screen_Recording_20250118_053045_StreetComplete.Dev.mp4

Or am I misunderstanding what is supposed to happen here? 🤷‍♂️

@westnordost
Copy link
Member Author

For it to work, a new version of the nsi-id-presets.json must be published which includes the preserveTags property in the data.

@westnordost
Copy link
Member Author

I just updated from the current NSI that includes the preserveTags. If you like, you could test again, @mnalis
(But I already tested the implementation, so I don't think it is required.)

@westnordost westnordost merged commit 01913d5 into master Feb 3, 2025
@FloEdelmann FloEdelmann deleted the preserveTags branch February 3, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants