Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch out country-specific presets #5970

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Patch out country-specific presets #5970

merged 4 commits into from
Oct 16, 2024

Conversation

westnordost
Copy link
Member

@westnordost westnordost commented Oct 16, 2024

@westnordost
Copy link
Member Author

Note for reviewers:

See https://raw.githubusercontent.com/openstreetmap/id-tagging-schema/main/dist/presets.json and search for "locationSet" to see what is removed/patched.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much cleaner than #5969 👍🙂

@westnordost
Copy link
Member Author

westnordost commented Oct 16, 2024

So, the following is patched out:

  • maxspeed sign had a different icon in US, CA, LR
  • office=bail_bond_agent was only available in US, PH
  • historic=memorial + memorial=stolperstein was only available in Europe
  • amenity=post_box had the field drive_through more prominently displayed in the US
  • amenity=townhall + townhall:type=barangay was only available in PH
  • highway=toll_gantry was not available in DE
  • network:type=node_network vertices were only available in BE, DE, LU, NL
  • man_made=footwear_decontamination was only available in AU, NZ (come on! As if it wasn't possible to have footwear decontamination facilities elsewhere! This is one good example why this whole thing reeks of shoehornification!)
  • trunk, motorway and primary road links showed advisory maxspeed more prominently than maxspeed, for some reason, in US, CA
  • "moped link roads" were only available in NL

Many of these are not relevant for StreetComplete, as preset fields are not used.

And for most, it is clear, that the intention is to just not show them in search results because such map features are not common / unusual / not known in whatever countries. But there is certainly not any particular reason why a "bail bond agent" couldn't exist in any other country than US, PH, just as footwear decontamination facilities could exist in any country.

@westnordost westnordost merged commit bcb8b58 into master Oct 16, 2024
@FloEdelmann FloEdelmann deleted the preset-postbox2 branch October 16, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No label / feature for post boxes
2 participants