-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n/ja: Add Japanese translation #963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I appreciate your efforts of adding new translations.
There are a couple of things which need to be fixed. A couple of translation strings were removed on the master branch yesterday, but your PR branch is based on an older commit (218d522), so if I'd merge it in this state, the build would fail. Please rebase onto master, which currently is 2bf7a54 and fix the annotated issues.
I will have a proper review later.
Resolves #961
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at the translations locally and couldn't find any layout issues apart from the settings main menu. I also checked some translations, but not everything. If there's anything unclear, please ask. Otherwise, this should be fine and if something needs further fixing, this can easily be done later on.
That last push unfortunately messed things up and one of the translation removals also removed too much. I will fix this manually on your branch before merging when everything else has been resolved, so that this doesn't make things unnecessarily complicated for you.
Thanks again for your translations.
Thanks again! |
Terms that were difficult to translate were translated using Chinese as a reference. Many IT terms were borrowed from English (they are usually written in katakana). In my testing, I noticed that the Japanese display was a bit large, but there was no problem using it.