Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables chat windows without address and bookmarks bars and also adds support for custom chat applications.
Previously, the chat was being opened by calling
require( "nw.gui" ).Shell.openExternal( url )
, so it was impossible #60 (comment) to hide the address and bookmarks bar of the browser window. To be able to do this, the browser executable had to be known, so special launch parameters could be set, but by usingopenExternal
there was no way of doing it.As I've already said here #9 (comment), I wanted to keep it as simple as possible. The most reasonable solution for me was adding a list of supported web browsers with predefined parameters, so those don't have to be inserted by the average user. Support for a custom command line has also been added, so different applications can be used, too.
I'm opening this pull request instead of just merging these changes, because I'd like to have some feedback first.
Right now, there's an issue with the Firefox implementation. The used parameters (
firefox -chrome http://www.twitch.tv/CHANNEL/chat
) should be correct, but the twitch chat refuses to load and I don't know why this is happening. I'm not a Firefox user, so if someone knows what's going on, please let me know, thanks.The dropdown is hidden behind the advanced settings, but I'm not sure if this is really needed.
Build instructions can be found here