fix: allow Uint8Array
s to be passed to FsWriteStream
#842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Volume write function declaration, we can see the second argument has a type of Buffer or Uint8Array.
memfs/src/volume.ts
Lines 1211 to 1218 in 0587738
However, FsWriteStream.prototype._write only allows a type of Buffer:
memfs/src/volume.ts
Lines 2569 to 2591 in 0587738
This issue does cause an error of the combination: webpack 5 + node-downloader-helper + memfs.
node-downloader-helper and its dependencies can call FsWriteStream.prototype._write with a data of type Uint8Array.
(If anyone has an interest for an example, please try my project https://github.com/MrMYHuang/taa with memfs 3.4.3.)
After applying my changes, this issues is fixed.