Fix types for federation

strawberry-graphql · Sep 6, 2021 · 54ad1f1 · 54ad1f1
1 parent 7d605b1
commit 54ad1f1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/strawberry/federation.py b/strawberry/federation.py
@@ -47,7 +47,7 @@ def field(
     provides: Optional[List[str]] = None,
     requires: Optional[List[str]] = None,
     external: bool = False,
-    init: Optional[Literal[False]] = False,
+    init: Literal[False] = False,
     permission_classes: Optional[List[Type[BasePermission]]] = None,
     deprecation_reason: Optional[str] = None,
     default: Any = UNSET,
@@ -65,7 +65,7 @@ def field(
     provides: Optional[List[str]] = None,
     requires: Optional[List[str]] = None,
     external: bool = False,
-    init: Optional[Literal[True]] = True,
+    init: Literal[True] = True,
     permission_classes: Optional[List[Type[BasePermission]]] = None,
     deprecation_reason: Optional[str] = None,
     default: Any = UNSET,

diff --git a/tests/pyright/test_federation.py b/tests/pyright/test_federation.py
@@ -17,6 +17,7 @@ def get_user_age() -> int:
 class User:
     name: str
     age: int = strawberry.field(resolver=get_user_age)
+    something_else: int = strawberry.federation.field(resolver=get_user_age)
 
 
 User(name="Patrick")
@@ -34,22 +35,22 @@ def test_pyright():
         Result(
             type="error",
             message='No parameter named "n" (reportGeneralTypeIssues)',
-            line=15,
+            line=16,
             column=6,
         ),
         Result(
             type="error",
             message='Argument missing for parameter "name" (reportGeneralTypeIssues)',
-            line=15,
+            line=16,
             column=1,
         ),
         Result(
-            type="info", message='Type of "User" is "Type[User]"', line=17, column=13
+            type="info", message='Type of "User" is "Type[User]"', line=18, column=13
         ),
         Result(
             type="info",
             message='Type of "User.__init__" is "(self: User, name: str) -> None"',
-            line=18,
+            line=19,
             column=13,
         ),
     ]