-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login and CurrentUser queries yield broken responses #421
Login and CurrentUser queries yield broken responses #421
Conversation
…nd clean up login flow to return either a user or raise an error. Not return None (which in turn raises a cryptic error
…upport an anonymous user, but at least shows a useful message rather then Cannot return null for non-nullable field Query.me.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 37 37
Lines 3119 3121 +2
=======================================
+ Hits 2722 2724 +2
Misses 397 397 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good in general :)
Some minor changes and we should be good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! :)
When doing a login with an incorrect username/password or querying me/current_user both cases result in a cryptical reponse:
This PR corrects this behaviour by raising an error and with an understandable error.
Types of Changes