Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build all profiles but test only those used in Aether #248

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

ccascone
Copy link
Member

@ccascone ccascone commented Apr 26, 2021

We decided to test only those profiles used in Aether to avoid hitting the Jenkins job execution timeout. This is a temporary measure, until we reduce PTF execution time (#238). In the meantime, to avoid messing up untested profiles too much, we should at least verify that we can build them.

@ccascone ccascone requested review from Yi-Tseng and osinstom April 26, 2021 18:08
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #248 (d2f13fb) into main (fec808b) will not change coverage.
The diff coverage is n/a.

❗ Current head d2f13fb differs from pull request most recent head 2eec4c3. Consider uploading reports for the commit 2eec4c3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main     #248   +/-   ##
=========================================
  Coverage     74.11%   74.11%           
  Complexity      273      273           
=========================================
  Files            18       18           
  Lines          1866     1866           
  Branches        153      153           
=========================================
  Hits           1383     1383           
  Misses          399      399           
  Partials         84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf80a...2eec4c3. Read the comment docs.

Copy link
Collaborator

@Yi-Tseng Yi-Tseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@osinstom osinstom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccascone ccascone merged commit c9492ea into main Apr 27, 2021
@ccascone ccascone deleted the build-all-test-few branch April 27, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants