Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow none body put post patch requests #232

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

aaronkarlsberg1
Copy link
Contributor

@aaronkarlsberg1 aaronkarlsberg1 commented Jan 13, 2023

Allow none body put post patch requests

update request example in this doc to not encode body if none on post put or patch:
https://strateos.atlassian.net/wiki/spaces/ENG/pages/1823801375/Onboarding+Request+Signing+Authentication+RSA+for+Strateos+Console+User

@aaronkarlsberg1 aaronkarlsberg1 requested a review from a team January 13, 2023 03:49
Copy link
Contributor

@sabrinamohabbat sabrinamohabbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for walking me through. All tests pass on my machine

@aaronkarlsberg1 aaronkarlsberg1 merged commit 6802295 into master Jan 17, 2023
@aaronkarlsberg1 aaronkarlsberg1 deleted the allow-none-body-put-post-patch-requests branch January 17, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants