Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk 50 v2 #716
sdk 50 v2 #716
Changes from 12 commits
ace0f16
ebc28a5
1b0bf83
190cc6d
1bd743d
2e5b0ef
85d52bd
2196665
43a831f
d69e2ec
bed003c
4e86fbe
92d5857
339d5ae
52eb9fe
79bbe45
c9539fd
33aa10d
c819b0c
8518e52
eea91cb
dd103da
18fdf1b
512b60a
9536aa6
86b2183
5b748bc
c2dc240
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should BeginBlockEvents/EndBlockEvents be replaced with FinalizeBlockEvents instead of just removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd need to defer to @catShaark on this. I am not sure, but thanks for the review and bringing this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @misko9, I just add the code u request.