Made jest test file extension name optional #2373
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2373 +/- ##
=======================================
Coverage 19.92% 19.92%
=======================================
Files 293 293
Lines 6484 6484
Branches 762 755 -7
=======================================
Hits 1292 1292
- Misses 4579 4615 +36
+ Partials 613 577 -36
Continue to review full report at Codecov.
|
| @@ -1,6 +1,6 @@ | |||
| import addons from '@storybook/addons'; | |||
|
|
|||
| const findTestResults = (testFiles, jestTestResults, jestTestFilesExt) => | |||
| const findTestResults = (testFiles, jestTestResults, jestTestFilesExt = "") => | |||
There was a problem hiding this comment.
I wonder if you ran git commit --no-verify instead of just git commit? We have a git hook which runs eslint in "fix" mode, which would replace those double quotes with single ones
There was a problem hiding this comment.
Likely didn't do yarn install, it's OK, we'll do a fix commit soon.
There was a problem hiding this comment.
Ok, I'll run yarn lint:js --fix after merging
There was a problem hiding this comment.
Yikes, noticed the double quotes after commiting, thanks!
|
Got to revert, sorry for confusion =( |
#2368:
What I did
Updated empty string to be used as default value for extension name, if it's not passed as an argument
How to test
Is this testable with jest or storyshots? Not sure
Does this need a new example in the kitchen sink apps? No
Does this need an update to the documentation? Not sure
If your answer is yes to any of these, please make sure to include it in your PR.