-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fileExt to be optional #2368
Comments
Looks like it's just a matter of using empty string as a default value. If anybody wants to make a PR, go for it |
If anyone new to storybook or open source in general wants to take this issue, I'm available to help! |
@ndelangen just dabbling into open source. Would make a PR. |
@Promhize
|
@ndelangen thanks. Looking to make further contributions. You all are awesome |
Already done. Check README here: https://github.com/storybooks/storybook/tree/master/addons/jest#withtestsoptions |
Done, but not released yet |
Actually it was release in 3.2.16 but not well documented: |
Oh. Should we revert #2373 then? |
Yes, please. Sorry for the lack of documentation regarding it. |
@Promhize drop by our slack channel. That way we can collaborate much easier and faster, if you want to do more collaboration I can help get you on-boarded on the project. |
Right now if you don't provide one this will append
undefined
to the end of the regex:https://github.com/storybooks/storybook/blob/087647673aedfe925496698a4e9c3a6106b967f4/addons/jest/src/index.js#L9
The text was updated successfully, but these errors were encountered: