Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fileExt to be optional #2368

Closed
kentcdodds opened this issue Nov 25, 2017 · 11 comments
Closed

Allow fileExt to be optional #2368

kentcdodds opened this issue Nov 25, 2017 · 11 comments

Comments

@kentcdodds
Copy link
Contributor

Moved from https://github.com/storybooks/storybook-addon-jest/issues/4

Right now if you don't provide one this will append undefined to the end of the regex:

https://github.com/storybooks/storybook/blob/087647673aedfe925496698a4e9c3a6106b967f4/addons/jest/src/index.js#L9

@Hypnosphi
Copy link
Member

Looks like it's just a matter of using empty string as a default value. If anybody wants to make a PR, go for it

@ndelangen
Copy link
Member

If anyone new to storybook or open source in general wants to take this issue, I'm available to help!

@promisetochi
Copy link
Contributor

promisetochi commented Nov 25, 2017

@ndelangen just dabbling into open source. Would make a PR.

@ndelangen
Copy link
Member

@Promhize
You'll have to

  1. Fork the repo
  2. Clone the forked repository to your computer
  3. Create a branch named feature/default-
  4. Edit the following file: addons/jest/src/index.js
    The change to apply: change line 3 from:
    const findTestResults = (testFiles, jestTestResults, jestTestFilesExt) =>
    to:
    const findTestResults = (testFiles, jestTestResults, jestTestFilesExt = '') =>
  5. Commit the changed file and push to the remote
  6. Go to our github page here: https://github.com/storybooks/storybook
  7. GitHub should suggest to open a PR, if it doesn't you should be able to select your branch and our master branch here to create one: https://github.com/storybooks/storybook/compare (our master branch should be the base.
  8. Describe the change you made in the title and description.
  9. Wait for someone to review the PR.
  10. It should be merged pretty quick!

@promisetochi
Copy link
Contributor

@ndelangen thanks. Looking to make further contributions. You all are awesome

@renaudtertrais
Copy link
Contributor

@Hypnosphi
Copy link
Member

Done, but not released yet

@renaudtertrais
Copy link
Contributor

Actually it was release in 3.2.16 but not well documented:
https://unpkg.com/@storybook/[email protected]/dist/index.js#pos_47

Commit: d185d1a#diff-c1ceced995a7529ca1ae8fcb2a0f4aafR26

@Hypnosphi
Copy link
Member

Oh. Should we revert #2373 then?

@renaudtertrais
Copy link
Contributor

Yes, please. Sorry for the lack of documentation regarding it.

@ndelangen
Copy link
Member

@Promhize drop by our slack channel.

That way we can collaborate much easier and faster, if you want to do more collaboration I can help get you on-boarded on the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants