Core: Fix default story sort #9482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/evect52u8 |
shilman
added
bug
core
patch:yes
tmeasday
approved these changes
Jan 16, 2020
|
@tmeasday correct. see my comment above in the PR description. |
|
Thanks! |
shilman
added
the
patch:done
ghost
mentioned this pull request
This was referenced Feb 12, 2020
This was referenced Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9477
What I did
Fix the story sorting logic, which I broke in #9424
How to test
See updated test cases.
@tmeasday NOTE: there were no other
dumpStorybook()tests instory_store.test.ts. there are a bunch ofgetStorybook()tests inclient_api.test.tsbut it's pretty messy to update those tests. i propose we add tests tostory_storeif needed.