Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade html-webpack-plugin #9367

Closed
wants to merge 1 commit into from
Closed

Upgrade html-webpack-plugin #9367

wants to merge 1 commit into from

Conversation

ndelangen
Copy link
Member

Issue: #9026

What I did

UPGRADE the dependency

@pllee

@ndelangen ndelangen added this to the 5.3.0 milestone Jan 9, 2020
@ndelangen ndelangen requested a review from shilman January 9, 2020 14:06
@ndelangen ndelangen self-assigned this Jan 9, 2020
@vercel
Copy link

vercel bot commented Jan 9, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/jpj841nu5
✅ Preview: https://monorepo-git-upgrade-html-webpack-plugin.storybook.now.sh

@shilman shilman changed the title FIX https://github.com/storybookjs/storybook/issues/9026 Upgrade html-webpack-plugin Jan 9, 2020
shilman
shilman requested changes Jan 10, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen Image loading now appears to be broken in Polymer on Chromatic. I re-ran the build just in case it was a random network thing, but it looks like a problem with the upgrade (or with our polymer implementation?)

@ndelangen
Copy link
Member Author

@shilman shilman modified the milestones: 5.3.0, 6.0.0 Jan 11, 2020
@ndelangen ndelangen closed this Jan 27, 2020
@nickpresta
Copy link

FWIW, our project had the same issue and upgrading to [email protected] fixed it. That doesn't mean this upgrade doesn't also break other things in the Storybook ecosystem, but at least for a fairly normal React project, upgrading to 4.0.0-beta.11 (via yarn resolutions) fixed things.

@ndelangen ndelangen reopened this Jun 2, 2020
@ndelangen ndelangen closed this Jun 2, 2020
@ndelangen ndelangen deleted the upgrade/html-webpack-plugin branch June 2, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman requested changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@naipath naipath Awaiting requested review from naipath

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
core dependencies
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ndelangen @nickpresta @shilman @phated