Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Check CRA is installed before showing warning #9346

Merged
merged 2 commits into from
Jan 7, 2020
Merged

React: Check CRA is installed before showing warning #9346

merged 2 commits into from
Jan 7, 2020

Conversation

atanasster
Copy link
Member

@atanasster atanasster commented Jan 7, 2020 •
edited by shilman
Loading

Issue: #9345

WARN Storybook support for Create React App is now a separate preset.
WARN To get started with the new preset, simply add `@storybook/preset-create-react-app` to your project.
WARN The built-in preset will be disabled in Storybook 6.0.

What I did

added check is CRA is installed at all before showing the warning

How to test

launch official-storybook, it should not show the warning

@vercel
Copy link

vercel bot commented Jan 7, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/fkgbmexu5
✅ Preview: https://monorepo-git-fork-atanasster-cra-warning-without-cra-installed.storybook.now.sh

@vercel vercel bot temporarily deployed to Preview January 7, 2020 16:30 Inactive
shilman
shilman approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @mrmckeb

@shilman shilman changed the title check if CRA is installed before showing the warning React: Check if CRA is installed before showing warning Jan 7, 2020
@shilman shilman added this to the 5.3.0 milestone Jan 7, 2020
@shilman shilman changed the title React: Check if CRA is installed before showing warning React: Check CRA is installed before showing warning Jan 7, 2020
@shilman shilman merged commit 7ba88f6 into storybookjs:next Jan 7, 2020
@shilman shilman deleted the cra-warning-without-cra-installed branch January 7, 2020 17:49
@mrmckeb
Copy link
Member

mrmckeb commented Jan 8, 2020

Good pickup!

@shilman shilman mentioned this pull request Jan 8, 2020
Closed
This was referenced Jan 20, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees
No one assigned
Labels
bug react
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@atanasster @mrmckeb @shilman