Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing options to react-test-renderer .create() method #896

Closed
wants to merge 16 commits into from
Closed

Allow passing options to react-test-renderer .create() method #896

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
af02d80
Allow passing options to react-test-renderer .create() method
jrdrg Apr 15, 2017
3d4d07c
fix lint errors
jrdrg Apr 15, 2017
f814ccc
add test script back
Apr 26, 2017
eec3a52
Update .jestrc to avoid problem with multiple storybook-addons instances
Apr 28, 2017
21bdb85
Updated to check for 'storybook' when determining whether to run stor…
Apr 28, 2017
20ca07c
add react-test-renderer as dev dependency
Apr 28, 2017
f1b1c31
resolve configPath from test dir
Apr 28, 2017
22ab2f3
Add .jestrc to storyshots dir so that test-examples script passes
Apr 28, 2017
8438988
fixed error in storyshots .jestrc
Apr 28, 2017
f2fdbc7
Extract storyshots package dependency check into a separate function
Apr 28, 2017
aff25fa
fix incorrect paths in .jestrc moduleNameMapper
Apr 28, 2017
431b6c3
remove storyshots/.jestrc
May 10, 2017
01f480a
update snapshot
May 11, 2017
bd7b71f
fix lint errors
May 18, 2017
7156191
move files to new path
May 18, 2017
136d62d
update snapshots
May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extract storyshots package dependency check into a separate function
  • Loading branch information
John Rodriguez authored and John Rodriguez committed May 18, 2017
commit f2fdbc7f6b2ee8701b0da04e8caff106bec402d1
16 changes: 8 additions & 8 deletions addons/storyshots/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ let configPath;

const babel = require('babel-core');

function hasDependency(pkg, dependency) {
return (pkg.devDependencies && pkg.devDependencies[dependency]) ||
(pkg.dependencies && pkg.dependencies[dependency]) ||
(pkg.name === dependency);
}

const pkg = readPkgUp.sync().pkg;
const isStorybook =
(pkg.devDependencies && pkg.devDependencies['@storybook/react']) ||
(pkg.dependencies && pkg.dependencies['@storybook/react']) ||
(pkg.name === 'storybook');

const isRNStorybook =
(pkg.devDependencies && pkg.devDependencies['@storybook/react-native']) ||
(pkg.dependencies && pkg.dependencies['@storybook/react-native']) ||
(pkg.name === '@storybook/react-native');
const isStorybook = hasDependency(pkg, '@storybook/react') || pkg.name === 'storybook';
const isRNStorybook = hasDependency(pkg, '@storybook/react-native');

export default function testStorySnapshots(options = {}) {
addons.setChannel(createChannel());
Expand Down