Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-loader: Selectively ignore typescript errors in generated code #7831

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 21, 2019

Issue: #7829

What I did

See #7829 (comment)

How to test

Don't have a repro handy, but it should be a safe change

@vercel
Copy link

vercel bot commented Aug 21, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@shilman shilman added this to the 5.2.0 milestone Aug 21, 2019
@shilman shilman requested a review from tmeasday August 21, 2019 00:57
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me

@shilman shilman merged commit bf79bfb into next Aug 21, 2019
@shilman shilman deleted the 7829-source-loader-tsignore branch August 21, 2019 02:47
@enagy27
Copy link
Contributor

enagy27 commented Aug 22, 2019

@shilman it looks like the syntax used here may not be available yet. I think the appropriate solution is to apply // @ts-ignore on each line 😞 will try to put up a PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants