Docs: Typescript Configuration Examples for v5 #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Typescript example code to reflect Webpack "full control" mode in Storybook v5.
jangerhofer
requested review from
Hypnosphi,
ndelangen and
shilman
as code owners
Codecov Report
@@ Coverage Diff @@
## next #5928 +/- ##
=======================================
Coverage 34.97% 34.97%
=======================================
Files 648 648
Lines 9480 9480
Branches 1333 1360 +27
=======================================
Hits 3316 3316
Misses 5534 5534
Partials 630 630Continue to review full report at Codecov.
|
shilman
added
configuration babel / webpack
documentation
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 7, 2019
Docs: Typescript Configuration Examples for v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for "full control" Webpack configuration has already been updated to reflect the changes made with version 5, however the Typescript sample code reflected version 4's configuration method prior to this PR.
These changes resolve the confusion of #5877.
Apologies if this should be submitted to
master-- if so, let me know and I will gladly re-submit!