Release: Prerelease 8.6.0-alpha.4 #30439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…torybook into norbert/typescript-upgrade
…torybook into norbert/typescript-upgrade
Build: Upgrade `typescript`
Docs: Update Next.js Tailwind example link
Docs: Add Preact-vite framework docs
RNW-Vite: Fix typos
…-component-ui Vite: Fix add component UI invalidation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
102 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -56,14 +56,14 @@ | |||
| "@storybook/vue3": "workspace:*", | |||
| "find-package-json": "^1.2.0", | |||
| "magic-string": "^0.30.0", | |||
| "typescript": "^5.0.0", | |||
| "typescript": "^5.7.3", | |||
There was a problem hiding this comment.
style: typescript dependency is duplicated in both dependencies and devDependencies - consider removing from one location
Suggested change
| "typescript": "^5.7.3", |
|
|
||
| #### `builder` | ||
|
|
||
| Type: `Record<string, any>` |
There was a problem hiding this comment.
style: Consider adding more specific type information beyond Record<string, any>
| @@ -42,7 +42,7 @@ const isVersionPublished = async ({ | |||
| `Unexpected status code when checking the current version on npm: ${response.status}` | |||
| ); | |||
| } | |||
| const data = await response.json(); | |||
| const data: any = await response.json(); | |||
There was a problem hiding this comment.
style: Consider defining a TypeScript interface for the npm registry response data structure instead of using any
| @@ -13,7 +13,7 @@ export const githubClient = (apiKey: string) => { | |||
| }), | |||
| }); | |||
|
|
|||
| const result = await res.json(); | |||
| const result: any = await res.json(); | |||
There was a problem hiding this comment.
style: Consider defining a proper interface for the GitHub API response instead of using any to maintain type safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.6.0-alpha.3to8.6.0-alpha.4.Once this pull request is merged, it will trigger a new release of version
8.6.0-alpha.4.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:typescript#30354If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.6.0-alpha.4
Greptile Summary
Based on the provided information, I'll create a concise summary of the PR that bumps the version from 8.6.0-alpha.3 to 8.6.0-alpha.4:
This release includes a Vite bug fix, documentation improvements, and a TypeScript upgrade to enable module mocking functionality.
code/builders/builder-vite/src/plugins/code-generator-plugin.tsto properly handle HMR for new storiesThe changes appear appropriate for a prerelease version bump, with proper testing and documentation updates included.