-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use UTC timezone in formatting too for knobs test #2861
Conversation
Please apply locale and tz to vue-kitchen-sink example as well |
Codecov Report
@@ Coverage Diff @@
## master #2861 +/- ##
=======================================
Coverage 35.82% 35.82%
=======================================
Files 428 428
Lines 9423 9423
Branches 969 959 -10
=======================================
Hits 3376 3376
- Misses 5392 5409 +17
+ Partials 655 638 -17
Continue to review full report at Codecov.
|
It looks like there is a date in the Angular stories (although it uses the built in date formatting), and the polymer tests |
LMK what you think we should do in the angular case @Hypnosphi |
Let's keep it as is until we hit any issues with angularshots |
Issue: #2859
Previously I fixed the TZ of the date itself but not the timezone we are formatting relative to.
What I did
Fixed both.
How to test
Run storyshots tests