Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTC timezone in formatting too for knobs test #2861

Merged
merged 4 commits into from
Jan 29, 2018

Conversation

tmeasday
Copy link
Member

Issue: #2859

Previously I fixed the TZ of the date itself but not the timezone we are formatting relative to.

What I did

Fixed both.

How to test

Run storyshots tests

@tmeasday tmeasday requested a review from Hypnosphi January 29, 2018 00:30
@Hypnosphi
Copy link
Member

Please apply locale and tz to vue-kitchen-sink example as well

@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label Jan 29, 2018
@codecov
Copy link

codecov bot commented Jan 29, 2018

Codecov Report

Merging #2861 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2861   +/-   ##
=======================================
  Coverage   35.82%   35.82%           
=======================================
  Files         428      428           
  Lines        9423     9423           
  Branches      969      959   -10     
=======================================
  Hits         3376     3376           
- Misses       5392     5409   +17     
+ Partials      655      638   -17
Impacted Files Coverage Δ
lib/core/src/client/manager/index.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 38.55% <0%> (ø) ⬆️
addons/links/src/react/components/link.js 78.78% <0%> (ø) ⬆️
lib/core/src/client/manager/preview.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Array.js 34.14% <0%> (ø) ⬆️
addons/actions/src/lib/util/prepareArguments.js 57.14% <0%> (ø) ⬆️
...ents/stories_panel/stories_tree/tree_decorators.js 34.37% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
addons/actions/src/lib/types/infinity/index.js 80% <0%> (ø) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bd011...d343b37. Read the comment docs.

@tmeasday
Copy link
Member Author

It looks like there is a date in the Angular stories (although it uses the built in date formatting), and the polymer tests

@tmeasday
Copy link
Member Author

LMK what you think we should do in the angular case @Hypnosphi

@Hypnosphi
Copy link
Member

Let's keep it as is until we hit any issues with angularshots

@tmeasday tmeasday merged commit 4ea7273 into master Jan 29, 2018
@tmeasday tmeasday deleted the tmeasday/fix-knobs-test branch January 29, 2018 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants