Don't always override NODE_ENV in build-storybook #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My webpack configuration uses the `DefinePlugin` to make `process.env.NODE_ENV` available to my react components, which in turn optionally do different things depending on the NODE_ENV (related to debugging and such). Unfortunately, these development-only features don't show up when I use `build-storybook` because `build-storybook` overrides `process.env.NODE_ENV`. While I think it is quite reasonable for `build-storybook` to default to a "production ready" build, it should not unconditionally override the `NODE_ENV` environment variable to do so. This change makes `"production"` the default, but also allows people to set a different `NODE_ENV` value and have it get used.
|
Yeah. This is great. |
|
Published with |
|
Thanks for accepting my change so quickly! |
This was referenced Aug 11, 2020
Closed
This was referenced Nov 25, 2020
Closed
Closed
This was referenced Dec 6, 2020
Closed
Closed
This was referenced Jun 30, 2021
|
View your CI Pipeline Execution ↗ for commit 1b43a66.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My webpack configuration uses the
DefinePluginto makeprocess.env.NODE_ENVavailable to my react components, which in turn optionally do different things depending on the NODE_ENV (related to debugging and such).Unfortunately, these development-only features don't show up when I use
build-storybookbecausebuild-storybookoverridesprocess.env.NODE_ENV.While I think it is quite reasonable for
build-storybookto default to a "production ready" build, it should not unconditionally override theNODE_ENVenvironment variable to do so.This change makes
"production"the default, but also allows people to set a differentNODE_ENVvalue and have it get used.