Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX the failing netlify builds #2527

Merged
merged 1 commit into from
Dec 21, 2017
Merged

FIX the failing netlify builds #2527

merged 1 commit into from
Dec 21, 2017

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Dec 21, 2017

Netlify will try to yarn install before running the script we provide.

We want to have more control before this process, to install some dependencies that -for some reason- do not install correctly.

What I did

I appended a --version to the yarn command that netlify uses before invoking the build script we provide.

This causes this install step to be skipped, and the build script to be executed immediately.

This seems to fix the issue.

@ndelangen ndelangen requested a review from cheapsteak December 21, 2017 07:40
@ndelangen ndelangen self-assigned this Dec 21, 2017
@ndelangen ndelangen added bug and removed bug labels Dec 21, 2017
@ndelangen ndelangen force-pushed the fix/netlify branch 2 times, most recently from 2b3c000 to d06b0ca Compare December 21, 2017 08:49
@storybookjs storybookjs deleted a comment from codecov bot Dec 21, 2017
@storybookjs storybookjs deleted a comment from codecov bot Dec 21, 2017
@codecov
Copy link

codecov bot commented Dec 21, 2017

Codecov Report

Merging #2527 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2527   +/-   ##
=======================================
  Coverage   16.87%   16.87%           
=======================================
  Files         307      307           
  Lines        7792     7792           
  Branches      782      784    +2     
=======================================
  Hits         1315     1315           
+ Misses       5853     5828   -25     
- Partials      624      649   +25
Impacted Files Coverage Δ
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
...ddons/actions/src/components/ActionLogger/index.js 5.26% <0%> (ø) ⬆️
...ents/src/manager/containers/CommentsPanel/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 41.41% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21.36% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cbc697...5bfae45. Read the comment docs.

@ndelangen ndelangen force-pushed the fix/netlify branch 3 times, most recently from 435b6dc to 1fb5019 Compare December 21, 2017 09:16
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Dec 21, 2017
@ndelangen ndelangen merged commit fb94010 into master Dec 21, 2017
@ndelangen ndelangen deleted the fix/netlify branch December 21, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant