Indexer: Ensure node_modules are excluded by default, unless explicitly included
#21611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes storybookjs#18640 * [x] exclude node_modules from the glob used for indexing stories by default unless explicitly specified * [x] show a little warning when node_modules is mentioned explicitly
sheriffMoose
changed the title
sheriffMoose
requested review from
ndelangen,
JReinhold and
tmeasday
as code owners
ndelangen
changed the title
node_modules are excluded by default, unless explicitly included
ndelangen
changed the title
node_modules are excluded by default, unless explicitly includednode_modules are excluded by default, unless explicitly included
|
@sheriffMoose Do you think you could fix the CI unit test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18640
What I did
How to test